Skip to content

Commit

Permalink
Merge pull request #4545 from mzazrivec/remove_unused_review_git_import
Browse files Browse the repository at this point in the history
Remove unused review_git_import() routine
  • Loading branch information
martinpovolny committed Aug 30, 2018
2 parents 298c323 + 06c3de3 commit bc91d95
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 51 deletions.
7 changes: 0 additions & 7 deletions app/controllers/miq_ae_tools_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -264,13 +264,6 @@ def check_git_task
end
end

def review_git_import
@message = params[:message]
@git_branches = params[:git_branches]
@git_tags = params[:git_tags]
@git_repo_id = params[:git_repo_id]
end

# Import classes
def upload
if params[:upload] && !params[:upload][:datastore].blank?
Expand Down
11 changes: 0 additions & 11 deletions app/views/miq_ae_tools/review_git_import.html.haml

This file was deleted.

1 change: 0 additions & 1 deletion config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2171,7 +2171,6 @@
import_export
log
resolve
review_git_import
review_import
),
:post => %w(
Expand Down
32 changes: 0 additions & 32 deletions spec/controllers/miq_ae_tools_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -237,38 +237,6 @@
end
end

describe "#review_git_import" do
include_context "valid session"

let(:params) do
{:git_branches => "git_branches", :git_tags => "git_tags", :git_repo_id => "123", :message => "the message"}
end

before do
bypass_rescue
end

it "assigns the git repo id" do
get :review_git_import, :params => params
expect(assigns(:git_repo_id)).to eq("123")
end

it "assigns the git branches" do
get :review_git_import, :params => params
expect(assigns(:git_branches)).to eq("git_branches")
end

it "assigns the git tags" do
get :review_git_import, :params => params
expect(assigns(:git_tags)).to eq("git_tags")
end

it "assigns the message" do
get :review_git_import, :params => params
expect(assigns(:message)).to eq("the message")
end
end

describe "#retrieve_git_datastore" do
include_context "valid session"

Expand Down

0 comments on commit bc91d95

Please sign in to comment.