Use miqObserveRequest to force dialog submit to wait for auto refresh

https://bugzilla.redhat.com/show_bug.cgi?id=1499589
ManageIQ · Oct 13, 2017 · c2701cc · c2701cc
1 parent b02c131
commit c2701cc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/app/assets/javascripts/dialog_field_refresh.js b/app/assets/javascripts/dialog_field_refresh.js
@@ -1,4 +1,4 @@
-/* global miqInitSelectPicker miqSelectPickerEvent miqSparkle miqSparkleOn */
+/* global miqInitSelectPicker miqObserveRequest miqSelectPickerEvent miqSparkle miqSparkleOn */
 
 var dialogFieldRefresh = {
   unbindAllPreviousListeners: function() {
@@ -238,7 +238,7 @@ var dialogFieldRefresh = {
   },
 
   sendRefreshRequest: function(url, data, doneFunction) {
-    miqJqueryRequest(url, {
+    miqObserveRequest(url, {
       data: data,
       dataType: 'json',
       beforeSend: true,

diff --git a/spec/javascripts/dialog_field_refresh_spec.js b/spec/javascripts/dialog_field_refresh_spec.js
@@ -923,4 +923,21 @@ describe('dialogFieldRefresh', function() {
       });
     });
   });
+
+  describe('#sendRefreshRequest', function() {
+    beforeEach(function() {
+      spyOn(window, 'miqObserveRequest');
+    });
+
+    it('delegates to miqObserveRequest', function() {
+      dialogFieldRefresh.sendRefreshRequest('the url', 'the data', 'the done function');
+      expect(window.miqObserveRequest).toHaveBeenCalledWith('the url', {
+        data: 'the data',
+        dataType: 'json',
+        beforeSend: true,
+        complete: true,
+        done: 'the done function'
+      });
+    });
+  });
 });