Use notification_link from decorators to redirect notification links

app/controllers/restful_redirect_controller.rb

@@ -1,19 +1,13 @@
 class RestfulRedirectController < ApplicationController
+  before_action :check_privileges
+
   def index
-    case params[:model]
-    when 'MiqRequest'
-      redirect_to :controller => 'miq_request', :action => 'show', :id => params[:id]
-    when 'VmOrTemplate'
-      klass = VmOrTemplate.select(:id, :type).find(params[:id]).try(:class)
-      controller = if klass && (VmCloud > klass || TemplateCloud > klass)
-                     'vm_cloud'
-                   else
-                     'vm_infra'
-                   end
-      redirect_to :controller => controller, :action => 'show', :id => params[:id]
+    redirect_params = params[:model].safe_constantize.try(:find, params[:id]).try(:decorate).try(:notification_link)
+    if redirect_params
+      redirect_to(redirect_params)
     else
-      flash_to_session(_("Could not find %{model}[id=%{id}]") % {:model => params[:model], :id => params[:id]})
-      redirect_to(:controller => 'dashboard')
+      flash_to_session(_("Could not find the given \"%{model}\" record.") % {:model => ui_lookup(:model => params[:model])}, :error)
+      redirect_to(:controller => 'dashboard', :action => 'show')
     end
   end
 end

app/decorators/miq_request_decorator.rb

@@ -7,4 +7,8 @@ def fonticon
       "pficon pficon-error-circle-o"
     end
   end
+
+  def notification_link
+    { :controller => 'miq_request', :action => 'show', :id => id }
+  end
 end

app/decorators/service_template_transformation_plan_request_decorator.rb

@@ -0,0 +1,5 @@
+class ServiceTemplateTransformationPlanRequestDecorator < MiqDecorator
+  def notification_link
+    nil
+  end
+end

app/decorators/vm_decorator.rb

@@ -37,4 +37,14 @@ def single_quad
       :fileicon => fileicon
     }
   end
+
+  def notification_link
+    klass = __getobj__.class
+    controller = if klass && (VmCloud > klass || TemplateCloud > klass)
+                   'vm_cloud'
+                 else
+                   'vm_infra'
+                 end
+    { :controller => controller, :action => 'show', :id => id }
+  end
 end