VMs and Templates: broken filtering on EmsFolders

[martinpovolny]

• Go to Compute --> Infra --> VMs
• Make sure the Vms & Template accordion/tree is selected
• Click on a folder

Problem: too many Vms and templates are displayed the EmsFolder criteria is ignored.

The data passed to /report_data is:

{"model_name":"VmOrTemplate",
"model":"VmOrTemplate",
"active_tree":"vandt_tree",
"explorer":true,
"additional_options":{"named_scope":["with_ems"],
"gtl_dbname":null,
"model":"VmOrTemplate",
"match_via_descendants":null,
"parent_id":10000000000010,
"parent_method":null,
"association":"all_vms_and_templates",
"view_suffix":null}}

It has parent_id set inside additional_options but not in the root params. However setting it would not help because the parend model is not being transfered. It is being guessed in
https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller.rb#L463

@karelhala: This looks very hacky to me and I don't see how the parent model shold be transfered in a systematic way.

@tumido : this comes from:
https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/vm_common.rb#L1141
I wonder if we could match the folders using a named scope instead?

Options for fixing:

• do something about the parent_id, parent_model make is so that it can be passwd through additional_options not guessed using controller_to_model and such

• add a named scope (if possible) to match given Datastore / EmsFolder. Not sure if it's is possible this seems to be some tree structure. I don't understand the modeling on the backend side here.

• hack for the release based on x_node, x_tree https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller.rb#L446 or https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller.rb#L450.

@karelhala, @tumido : thoughts?