New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parent class name to additional options for report data #2640
Conversation
@martinpovolny I am not sure if function @miq-bot add_label GTLs, gaprindashvili/yes, bug |
@karelhala Cannot apply the following label because they are not recognized: gtls |
Code looks good. Any volunteer to test this? We need to click throught the different GTL usecases with this PR merged. @AparnaKarve, @lgalis, @h-kataria, @mzazrivec, @ZitaNemeckova ? @karelhala : from the security perspective I am not happy we are constantizing any value that comes from the input and then calling find on it. Maybe we could at least check that the class is a subclass of |
@martinpovolny i will try to test that out in UI, additional set of testing is always good. |
cd10c80
to
65f795d
Compare
65f795d
to
f2ea405
Compare
Checked commit karelhala@f2ea405 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
@martinpovolny tested in UI so far looks good. |
Thx! |
Add parent class name to additional options for report data (cherry picked from commit 62562b6)
Gaprindashvili backport details:
|
Fixes #2632
Parent is not all the times just class from which
/report_data
was called, so sendparent_class_name
as well so we can query for more specific items.