Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent class name to additional options for report data #2640

Merged
merged 1 commit into from Nov 7, 2017

Conversation

karelhala
Copy link
Contributor

Fixes #2632

Parent is not all the times just class from which /report_data was called, so send parent_class_name as well so we can query for more specific items.

@karelhala
Copy link
Contributor Author

@martinpovolny I am not sure if function from_additional_options is good, can you look at it and maybe propose some better thing?

@miq-bot add_label GTLs, gaprindashvili/yes, bug

@miq-bot
Copy link
Member

miq-bot commented Nov 6, 2017

@karelhala Cannot apply the following label because they are not recognized: gtls

@martinpovolny
Copy link

Code looks good. Any volunteer to test this? We need to click throught the different GTL usecases with this PR merged.

@AparnaKarve, @lgalis, @h-kataria, @mzazrivec, @ZitaNemeckova ?

@karelhala : from the security perspective I am not happy we are constantizing any value that comes from the input and then calling find on it. Maybe we could at least check that the class is a subclass of ActiveRecord::Base?

@martinpovolny martinpovolny self-assigned this Nov 6, 2017
@h-kataria
Copy link
Contributor

@martinpovolny i will try to test that out in UI, additional set of testing is always good.

@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2017

Checked commit karelhala@f2ea405 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@h-kataria
Copy link
Contributor

@martinpovolny tested in UI so far looks good.

@martinpovolny martinpovolny merged commit 62562b6 into ManageIQ:master Nov 7, 2017
@martinpovolny martinpovolny added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 7, 2017
@martinpovolny
Copy link

Thx!

simaishi pushed a commit that referenced this pull request Nov 15, 2017
Add parent class name to additional options for report data
(cherry picked from commit 62562b6)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit cfacf25d6600a573608636b5e0ba32dd29beff74
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Tue Nov 7 20:40:42 2017 +0100

    Merge pull request #2640 from karelhala/gtlAddParentClassName
    
    Add parent class name to additional options for report data
    (cherry picked from commit 62562b696421856681c037bbd5ba697cd15732da)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants