Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Search/Advanced Search in Ansible Playbooks/Repositories/Credentials page #6765

Closed
hstastna opened this issue Mar 12, 2020 · 8 comments

Comments

@hstastna
Copy link
Contributor

Go to Automation > Ansible > Playbooks/Repositories/Credentials page and you can see that in accordion, there's No filters defined. (or maybe some filters already?) but you cannot define any filter because of missing Advanced Search button on the right of the page.

Also it is not possible to search through items in the list. Search not present, too:
credentials

@hstastna
Copy link
Contributor Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Mar 12, 2020
@himdel
Copy link
Contributor

himdel commented Mar 12, 2020

I'm not sure there was ever supposed to be any search or advanced search there.

I think what you're seeing is a screen with no search, and a default listnav which just says no filters.

(IMO it doesn't sound like a bug, but once we have support for listnav-less layouts, we may want to use them here.)

@hstastna
Copy link
Contributor Author

hstastna commented Mar 13, 2020

@himdel So from what I understand, the bug here for now is the misleading text in accordion.

@h-kataria
Copy link
Contributor

@hstastna it looks like we should not render listnav partial for these screens.

hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 24, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 24, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 24, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 24, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 25, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 26, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 27, 2020
@h-kataria
Copy link
Contributor

@hstastna having nameonly search makes sense on all list views, but listnav should only be visible if we list can have advanced search, without advanced search there is no way a user can add filters to the screen. So, we should make changes to code to display nameonly search on the screen and hide the listnav when advanced search is not allowed.

hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 30, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 31, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Mar 31, 2020
@himdel
Copy link
Contributor

himdel commented Mar 31, 2020

Linking with #6356

Maybe instead of adding search to the no-listnav layout, we can move simple search to toolbars.
(Although, toolbar search has to be react, so maybe it's faster to just add the existing one to the layout, if doable.)

@hstastna
Copy link
Contributor Author

hstastna commented Mar 31, 2020

I like the idea about moving Search to toolbar but according to the comment it's faster and easily doable to just add the existing Search to the layout, at least for now.

hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 1, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 2, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 3, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 3, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 3, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 3, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 3, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 3, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 7, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 8, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 13, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 14, 2020
hstastna added a commit to hstastna/manageiq-ui-classic that referenced this issue Apr 15, 2020
@himdel
Copy link
Contributor

himdel commented Apr 15, 2020

Fixed in #6810

@himdel himdel closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants