New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces default icons for “catalog” and “catalog items” #1024
Conversation
@gmcculloug @dclarizio Please review |
@epwinchell unrecognized command 'bug', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
@epwinchell 'gmcculloug' is an invalid assignee, ignoring... |
Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/0ab3a09cd02eb9f790fa86540c12e8f51cf7c255 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@miq-bot add_label bug, graphics, fine/yes |
@miq-bot assign @dclarizio |
Looks good, but wondering if there is also a way to visually separate Catalog Bundles and Catalog Items when no custom image is specified. Since a bundle is just a collection of items maybe it can show multiple boxes? This, of course, depends on if we can distinguish the object type. The value for the Bundle or Item is stored in the |
Created an issue for @gmcculloug's request. (cherry picked from commit e4d0328)
Fine backport details:
|
This PR replaces the "T" used to represent catalogs with a closed folder in: service catalogs, catalog items, and catalogs. It also replaces the default icon "T" used to represent catalog items with a cube.
Relates to: #971
https://bugzilla.redhat.com/show_bug.cgi?id=1439779
Old
New