Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces default icons for “catalog” and “catalog items” #1024

Merged
merged 1 commit into from Apr 12, 2017
Merged

Replaces default icons for “catalog” and “catalog items” #1024

merged 1 commit into from Apr 12, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Apr 12, 2017

This PR replaces the "T" used to represent catalogs with a closed folder in: service catalogs, catalog items, and catalogs. It also replaces the default icon "T" used to represent catalog items with a cube.

Relates to: #971

https://bugzilla.redhat.com/show_bug.cgi?id=1439779

Old
screen shot 2017-04-12 at 3 02 39 pm

New
screen shot 2017-04-12 at 2 59 16 pm

@epwinchell
Copy link
Contributor Author

@gmcculloug @dclarizio Please review
cc @skateman

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

@epwinchell unrecognized command 'bug', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

@epwinchell 'gmcculloug' is an invalid assignee, ignoring...

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/0ab3a09cd02eb9f790fa86540c12e8f51cf7c255 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🍰

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, graphics, fine/yes

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@gmcculloug
Copy link
Member

Looks good, but wondering if there is also a way to visually separate Catalog Bundles and Catalog Items when no custom image is specified. Since a bundle is just a collection of items maybe it can show multiple boxes?

This, of course, depends on if we can distinguish the object type. The value for the Bundle or Item is stored in the service_type field as composite or atomic. cc @skateman

@dclarizio dclarizio merged commit e4d0328 into ManageIQ:master Apr 12, 2017
@dclarizio dclarizio added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 12, 2017
simaishi pushed a commit that referenced this pull request Apr 13, 2017
Created an issue for @gmcculloug's request.
(cherry picked from commit e4d0328)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 0c39697744fefda4c18005dec4924ae86b8c10d6
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Apr 12 12:56:06 2017 -0700

    Merge pull request #1024 from epwinchell/catalog_icons
    
    Created an issue for @gmcculloug's request.
    (cherry picked from commit e4d03284d7bb046ca3b35aee45ce4894bb31754b)

@epwinchell epwinchell deleted the catalog_icons branch October 25, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants