Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Save' button state in Edit Management Engine Relationship for VM/Instance #1055

Conversation

bmclaughlin
Copy link
Contributor

Reset 'Save' button to nil when no server is selected to disable the button.

https://bugzilla.redhat.com/show_bug.cgi?id=1442736

@bmclaughlin
Copy link
Contributor Author

@miq-bot add_labels bug, compute/infrastructure, compute/cloud

@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2017

Checked commits bmclaughlin/manageiq-ui-classic@f7cdbda~...4799824 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@h-kataria h-kataria added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 18, 2017
@h-kataria
Copy link
Contributor

looks good

@h-kataria h-kataria merged commit d35b1ca into ManageIQ:master Apr 18, 2017
@bmclaughlin bmclaughlin deleted the disable-save-button-when-no-server-selected branch April 18, 2017 18:10
simaishi pushed a commit that referenced this pull request Apr 19, 2017
…-server-selected

Fix 'Save' button state in Edit Management Engine Relationship for VM/Instance
(cherry picked from commit d35b1ca)

https://bugzilla.redhat.com/show_bug.cgi?id=1443243
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit de46ef59b7b3873fa5fd1a6d5aa86326042fcb90
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Apr 18 14:00:35 2017 -0400

    Merge pull request #1055 from bmclaughlin/disable-save-button-when-no-server-selected
    
    Fix 'Save' button state in Edit Management Engine Relationship for VM/Instance
    (cherry picked from commit d35b1ca02d0fb3efc7876a27586170d87b8658b4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1443243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants