Hide resolved alerts #1070
Merged
Hide resolved alerts #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit moolitayer@eee0141 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@enoodle can you please review this change? |
|
LGTM 👍 |
|
@enoodle please review |
enoodle
approved these changes
Apr 24, 2017
|
@dclarizio could you please review? |
|
@moolitayer looks good to me, I'll merge, but it won't go to Fine without the label and a BZ, so please follow up with fine/yes or no. |
|
@dclarizio Thanks for reviewing @miq-bot add_label fine/no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only open alerts should be visible in the screen. Currently for most alert type, resolved is always nil, this effects mostly container providers