Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed no flash message issue while retiring a service #1101

Merged
merged 2 commits into from Apr 24, 2017
Merged

Fixed no flash message issue while retiring a service #1101

merged 2 commits into from Apr 24, 2017

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Apr 20, 2017 •
edited

This issue is visible from the Service Summary page.

To fix this, the service_retire_now method was added that was missed while refactoring x_ button in service_controller
(can be traced back to this commit: 497f89a)

https://bugzilla.redhat.com/show_bug.cgi?id=1442112

@mzazrivec Please review.

@miq-bot
Copy link
Member

miq-bot commented Apr 20, 2017

Checked commits AparnaKarve/manageiq-ui-classic@fba25dc~...63b792b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. ⭐

@AparnaKarve AparnaKarve reopened this Apr 20, 2017
@AparnaKarve AparnaKarve changed the title Fixed no flash message issue while retiring service Fixed no flash message issue while retiring a service Apr 20, 2017
@mzazrivec mzazrivec self-assigned this Apr 24, 2017
@mzazrivec mzazrivec added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 24, 2017
@mzazrivec mzazrivec merged commit 4312964 into ManageIQ:master Apr 24, 2017
simaishi pushed a commit that referenced this pull request Apr 24, 2017
@mzazrivec @simaishi
Merge pull request #1101 from AparnaKarve/bz1442112_no_flash_retiring…
d8f65f1 
…_service

Fixed no flash message issue while retiring a service
(cherry picked from commit 4312964)

https://bugzilla.redhat.com/show_bug.cgi?id=1444968
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit d8f65f1b96366dc016cb686d90b468812d727b88
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Apr 24 10:05:06 2017 +0200

    Merge pull request #1101 from AparnaKarve/bz1442112_no_flash_retiring_service
    
    Fixed no flash message issue while retiring a service
    (cherry picked from commit 431296483b057834ff0e825ab1970c3c1df0e97d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1444968

@AparnaKarve AparnaKarve deleted the bz1442112_no_flash_retiring_service branch July 26, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AparnaKarve @miq-bot @simaishi @mzazrivec