Display error message correctly that is returned from model. #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display correct flash message when there is an error deleting Catalog Item https://bugzilla.redhat.com/show_bug.cgi?id=1443120
mzazrivec
reviewed
Apr 24, 2017
| {:record => ui_lookup(:table => "service_template")}) if @flash_array.nil? | ||
| self.x_node = "root" | ||
| if @flash_array.nil? | ||
| add_flash(_("The selected %{record} was deleted") % |
There was a problem hiding this comment.
I know this has been there before, but for the sake of translators and nicer translations, we'd like
to get rid of calling ui_lookup() on a static string. So I'd suggest to change the above string to:
"The selected Catalog Item was deleted"
|
@mzazrivec addressed feedback. |
|
Checked commits h-kataria/manageiq-ui-classic@78451fe~...caccd80 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 LGTM - once green |
|
JS errors are unrelated to this PR as there are no JS changes, merging. |
simaishi
pushed a commit
that referenced
this pull request
Apr 25, 2017
Display error message correctly that is returned from model. (cherry picked from commit a0d684c) https://bugzilla.redhat.com/show_bug.cgi?id=1445108
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display correct flash message when there is an error deleting Catalog Item
https://bugzilla.redhat.com/show_bug.cgi?id=1443120
@syncrou please review/test