Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy Event must have at least one action assigned to it #112

Merged
merged 1 commit into from Jan 10, 2017

Conversation

h-kataria
Copy link
Contributor

Made changes to not allow deleting all actions from a Policy Event, at least one action should be there.

https://bugzilla.redhat.com/show_bug.cgi?id=1395965

before:
before

after:
after

@dclarizio please review

@h-kataria
Copy link
Contributor Author

@Ladas can you take a look failing tests on this PR, those are unrelated to changes in this PR, seems to be failing in NetworkRouterController

@Ladas
Copy link
Contributor

Ladas commented Jan 10, 2017

@gildub @tzumainn can you check out the CI failure? Seems like some specs you added recently?

@Ladas
Copy link
Contributor

Ladas commented Jan 10, 2017

@h-kataria seems like it's fixed in #115, so you just need to rebase

@gildub
Copy link
Contributor

gildub commented Jan 10, 2017

@h-kataria, @Ladas, yes I confirm, sorry about the split issue!

Made changes to not allow deleting all actions from a Policy Event, at least one action should be there.

https://bugzilla.redhat.com/show_bug.cgi?id=1395965
@miq-bot
Copy link
Member

miq-bot commented Jan 10, 2017

Checked commit h-kataria@92d6591 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 1 offense detected

spec/controllers/miq_policy_controller/events_spec.rb

@dclarizio dclarizio merged commit 3d34785 into ManageIQ:master Jan 10, 2017
@dclarizio dclarizio added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 10, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 6f16b752b25c7eb15ff43230327f127f646a7c19
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Tue Jan 10 10:07:10 2017 -0800

    Merge pull request #112 from h-kataria/policy_event_action_fix
    
    Policy Event must have at least one action assigned to it
    (cherry picked from commit 3d34785eff8ce66ef2ca7304fcffd8794d7dc6cf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1413119

@h-kataria h-kataria deleted the policy_event_action_fix branch February 7, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants