Find correct klass for rbac check for retirevms
#1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just kidding, this will ensure we populate rec_cls variable first before the klass variable. That way we can re-use the rec_cls when populating klass variable.
One would think that retirevms method would operate on Vm records. That's not the case. Caveat programmer! Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1442691 Introduced in 457b085. Addressing: Error caught: [NoMethodError] undefined method `all' for nil:NilClass lib/rbac/filterer.rb:545:in `apply_scope' lib/rbac/filterer.rb:205:in `search' lib/rbac/filterer.rb:112:in `search' lib/rbac.rb:3:in `search' manageiq-ui-classic-d32ec1b1bfc2/app/controllers/application_controller.rb:2265:in `assert_rbac' manageiq-ui-classic-d32ec1b1bfc2/app/controllers/mixins/checked_id_mixin.rb:35:in `find_checked_ids_with_rbac' manageiq-ui-classic-d32ec1b1bfc2/app/controllers/application_controller/ci_processing.rb:219:in `retirevms'
|
@miq-bot assign @martinpovolny |
|
Checked commits https://github.com/isimluk/manageiq-ui-classic/compare/0732b5e90c2b78859b66ad124aac8ba821f81196~...414a9fb9e3c136eba9f615d2029318675bbb2f0f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
martinpovolny
modified the milestones:
Sprint 59 Ending Apr 24, 2017,
Sprint 60 Ending May 8, 2017
simaishi
pushed a commit
that referenced
this pull request
Apr 25, 2017
Find correct klass for rbac check for `retirevms` (cherry picked from commit d7743ae) https://bugzilla.redhat.com/show_bug.cgi?id=1445283
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One would think that retirevms method would operate on Vm records.
That's not the case. Caveat programmer!
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1442691
Introduced in 457b085.
Addressing:
@miq-bot add_label bug, fine/yes