Use correct params for find_record_with_rbac in resize method

[petrblaho]

find_record_with_rbac expects ActiveRecord like class as first parameter.
During previous refactoring a mistake was introduced and session[:userid] was
passed as first parameter and that caused "undefined method `find_by' for
"admin":String [vm/resize]" when trying to go to reconfigure a VM dialog page.

This corrects that.

https://bugzilla.redhat.com/show_bug.cgi?id=1445005

[romanblanco]

@miq-bot add_label bug, rbac

[petrblaho]

How to reproduce original issue (assuming master manageiq, manageiq-ui-classic and manageiq-providers-openstack repos):

1. Have a VM with OpenStack Cloud provider and more than 1 Flavor.
2. Select VM from a list of VM or go to VM's detail page.
3. Click on "Configuration" in toolbar, then "Reconfigure selected/this instance"

Result without this patch: error page with "undefined method `find_by' for
"admin":String [vm/resize]" message.
Result with patch: reconfigure dialog page for VM

[petrblaho]

Error page after step 3 without patch:

[petrblaho]

Result of the same actions after applying patch:

[miq-bot]

Checked commit https://github.com/petrblaho/manageiq-ui-classic/commit/52c029d8999a5859c92b57efedff57bdfe171a18 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

[tzumainn]

@miq-bot label fine/yes

[tzumainn]

@miq-bot add_label fine/yes

[miq-bot]

@tzumainn unrecognized command 'label', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

[tzumainn]

@miq-bot add_label blocker

[simaishi]

@petrblaho The refactoring PR (#919) is not in Fine branch and I'm not sure what change is needed in Fine if any. Can you please create a Fine PR?

FYI, the current Fine branch has:

def resize
    @record ||= VmOrTemplate.find_by_id(params[:rec_id])

[petrblaho]

@simaishi this PR solved issue introduced by #919 as you noted. So I think this is not needed in fine. I cannot reproduce https://bugzilla.redhat.com/show_bug.cgi?id=1445005 on fine branch.

[simaishi]

@petrblaho Thanks for the confirmation, removed the flags.