Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename column header in Container Template screen #1147

Merged
merged 1 commit into from May 25, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Apr 25, 2017

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1434760

Adding a note to clarify that the objects names can consist of parameters.

objectste

@zakiva
Copy link
Contributor Author

zakiva commented Apr 25, 2017

@miq-bot add_label compute/containers, bug

@zakiva
Copy link
Contributor Author

zakiva commented Apr 25, 2017

@simon3z @zeari I'm not sure if this hint is enough please take a look

@dclarizio dclarizio self-assigned this Apr 25, 2017
@dclarizio
Copy link

Awaiting feedback on #1147 (comment) from @simon3z / @zeari . . . we're green and can merge if we get the 👍

@zeari
Copy link

zeari commented Apr 25, 2017

@dclarizio Good enough for me but its up to @simon3z. I think Its really more up to to users to know that openshift generates names. Maybe we can distinguish between names that the user is required to fill out and the ones that are auto generated?

@zakiva zakiva force-pushed the rename_template_header branch 2 times, most recently from 864ed33 to d8160b0 Compare May 1, 2017 09:32
@zakiva
Copy link
Contributor Author

zakiva commented May 1, 2017

@epwinchell Can you please take a look? I'm not sure regarding the text styling here.

@epwinchell
Copy link
Contributor

@zakiva Looks fine

@simon3z
Copy link
Contributor

simon3z commented May 10, 2017

@zakiva @epwinchell I have the feeling that the note should look like more a note (e.g. smaller font, maybe gray, closer to the table).
If you don't think that's the case then LGTM 👍

@epwinchell
Copy link
Contributor

epwinchell commented May 10, 2017

@zakiva
Copy link
Contributor Author

zakiva commented May 11, 2017

@zakiva Try using %small rather than %h4 (https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/typography-2.html)

@epwinchell done, thanks

note3

@miq-bot
Copy link
Member

miq-bot commented May 11, 2017

Checked commit zakiva@0e56479 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@zakiva
Copy link
Contributor Author

zakiva commented May 21, 2017

@dclarizio Can you please review/merge?

@dclarizio dclarizio merged commit 03b8ff1 into ManageIQ:master May 25, 2017
@dclarizio dclarizio added this to the Sprint 62 Ending Jun 5, 2017 milestone May 25, 2017
simaishi pushed a commit that referenced this pull request Jun 9, 2017
Rename column header in Container Template screen
(cherry picked from commit 03b8ff1)

https://bugzilla.redhat.com/show_bug.cgi?id=1460372
@simaishi
Copy link
Contributor

simaishi commented Jun 9, 2017

Fine backport details:

$ git log -1
commit a56327fb96e8de1968434193a6ea93bdf05360b7
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu May 25 09:33:28 2017 -0700

    Merge pull request #1147 from zakiva/rename_template_header
    
    Rename column header in Container Template screen
    (cherry picked from commit 03b8ff1882fa1a973dd146a6157fbb42902f5c87)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants