Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing icons into automate simulation results tree #1153

Merged
merged 1 commit into from Apr 25, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented Apr 25, 2017

Also display just a warning if an icon is missing

https://bugzilla.redhat.com/show_bug.cgi?id=1445089

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2017

Checked commit skateman@40e2630 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@himdel himdel closed this Apr 25, 2017
@himdel himdel reopened this Apr 25, 2017
@h-kataria h-kataria added this to the Sprint 60 Ending May 8, 2017 milestone Apr 25, 2017
@h-kataria h-kataria merged commit b6d814f into ManageIQ:master Apr 25, 2017
@skateman skateman deleted the simulate-missing-icons branch April 25, 2017 16:39
simaishi pushed a commit that referenced this pull request Apr 26, 2017
Add some missing icons into automate simulation results tree
(cherry picked from commit b6d814f)

https://bugzilla.redhat.com/show_bug.cgi?id=1445900
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit a4f160439c450bea6a2e9667b630a0b790542bb7
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Tue Apr 25 12:36:28 2017 -0400

    Merge pull request #1153 from skateman/simulate-missing-icons
    
    Add some missing icons into automate simulation results tree
    (cherry picked from commit b6d814f61795a5a12ae8103d15ff3c4c74cb3a53)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants