Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VmCloud Resize/Reconfigure form bugs #1163

Merged
merged 3 commits into from Apr 27, 2017

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Apr 26, 2017

This fixes a bug where the buttons on the Resize form don't work if you access the form from outside of an explorer view.
https://bugzilla.redhat.com/show_bug.cgi?id=1445011

This also fixes a bug where retrieving data to populate the form throws an exception because the VM to be resized does not have a flavor.
https://bugzilla.redhat.com/show_bug.cgi?id=1445018

@mansam
Copy link
Contributor Author

mansam commented Apr 26, 2017

@tzumainn @petrblaho

@tzumainn
Copy link
Contributor

@miq-bot add_lable blocker,bug,fine/yes

@tzumainn
Copy link
Contributor

@miq-bot add_label blocker,bug,fine/yes

@miq-bot
Copy link
Member

miq-bot commented Apr 26, 2017

@tzumainn unrecognized command 'add_lable', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miq-bot
Copy link
Member

miq-bot commented Apr 26, 2017

Checked commits mansam/manageiq-ui-classic@394aeb8~...00d4ba9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec added this to the Sprint 60 Ending May 8, 2017 milestone Apr 27, 2017
@mzazrivec mzazrivec merged commit 8d7b700 into ManageIQ:master Apr 27, 2017
@petrblaho
Copy link

I think that only solution to https://bugzilla.redhat.com/show_bug.cgi?id=1445018 should be applied to Fine as https://bugzilla.redhat.com/show_bug.cgi?id=1445011 is not reproducible on Fine b/c it works on code introduced by #919 and this is not backported to Fine branch.

So I suggest backporting only 394aeb8 and 00d4ba9 to Fine branch.

What do you thing? @mansam @tzumainn @mzazrivec @simaishi

@tzumainn
Copy link
Contributor

@petrblaho makes sense to me - my fault for forgetting you were testing on master

@tzumainn
Copy link
Contributor

@mansam Can you create a Fine backport for this that only includes the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1445018 ?

@simaishi
Copy link
Contributor

I was about to backport this, perfect timing 😄 Will wait for a Fine PR.

@simaishi
Copy link
Contributor

Backported to Fine via #1186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants