Fix duplicate DOM id when saving advanced search. #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generiv tree partial contains the div being replaced so we need to call 'replace' rather than 'replace_html'. Second, the forman related partial does not exist at all therefor the branch is a nonsense.
isimluk
reviewed
Apr 27, 2017
| @@ -450,14 +450,10 @@ def adv_search_button | |||
| if ["delete", "saveit"].include?(params[:button]) | |||
| if @edit[:in_explorer] || x_active_tree == :storage_tree | |||
| tree_name = x_active_tree.to_s | |||
| if "configuration_manager_cs_filter_tree_tree" == tree_name | |||
| page.replace_html("#{tree_name}_div", :partial => "provider_foreman/#{tree_name}") | |||
| else | |||
There was a problem hiding this comment.
Yeah, this is worth removal.
But it was added recently (d63b47e).
There was a problem hiding this comment.
My ❤️ can feel the pain 😢
|
Checked commit martinpovolny@efc38b6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/application_controller/filter.rb
|
|
ping @himdel : I am not going to remove the other dead code in this PR. That needs to be done in a separate one. Please, merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generiv tree partial contains the div being replaced so we need to
call 'replace' rather than 'replace_html'.
Second, the forman related partial does not exist at all therefor the
branch is a nonsense.
ping @isimluk