Fixed quadicon text links. #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h-kataria : the travis failure seems related, pls, fix it |
h-kataria
force-pushed
the
quadicon_title_link_fix
branch
from
45a9f00
to
25b2bae
Compare
- Links when clicking on quadicon title text were broken when going to any grid/tile view thru relationships. i.e "Provider -> list of Hosts", "Provider -> List of VMs". Changed code to use same method to determine link that is being used to generate link for actual quadicon. - Fixed existing spec tests appropriately. https://bugzilla.redhat.com/show_bug.cgi?id=1446212
h-kataria
force-pushed
the
quadicon_title_link_fix
branch
from
25b2bae
to
1522c82
Compare
|
Checked commit h-kataria@1522c82 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 28, 2017
Fixed quadicon text links. (cherry picked from commit 70ba36c) https://bugzilla.redhat.com/show_bug.cgi?id=1446734
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1446212
@hayesr @dclarizio please review.