Initialize the delete_backing flag for existing VM disks in the reconfigure form #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, fine/yes, euwe/yes |
lgalis
force-pushed
the
initialize_delete_backing_for_vm_disk_reconfigure
branch
from
9e324ff
to
e34672c
Compare
|
Checked commits lgalis/manageiq-ui-classic@fc90caf~...e34672c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lgalis
changed the title
|
@dclarizio or @h-kataria - please review |
h-kataria
approved these changes
May 8, 2017
|
@lgalis Is there a BZ for this? Can you please create if it doesn't exist? |
|
@simaishi - added the BZ link in the PR description |
|
@miq-bot remove_label bugzilla needed |
|
@lgalis please remove the |
|
@miq-bot remove_label euwe/conflict |
|
@lgalis unrecognized command 'add', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
simaishi
pushed a commit
that referenced
this pull request
Jun 6, 2017
…_disk_reconfigure Initialize the delete_backing flag for existing VM disks in the reconfigure form (cherry picked from commit 8a195f6) https://bugzilla.redhat.com/show_bug.cgi?id=1459264
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize the delete_backing flag for existing VM disks in the reconfigure form
https://bugzilla.redhat.com/show_bug.cgi?id=1445818
Before:
After: