Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network data in physical server page #1200

Closed
wants to merge 1 commit into from
Closed

Add network data in physical server page #1200

wants to merge 1 commit into from

Conversation

CharlleDaniel
Copy link
Member

@CharlleDaniel CharlleDaniel commented Apr 28, 2017

This PR is able to:
Create new session of networks details in the physical server page using attributes of "guest_devices.network" .
Was added the following attributes in the session:
- Mac Address
- IPV4 Address
- IPV6 Address
Depends on:

network_session

@CharlleDaniel CharlleDaniel changed the title Add network data in physical server details table [WIP] Add network data in physical server details table Apr 28, 2017
@miq-bot miq-bot added the wip label Apr 28, 2017
@miq-bot
Copy link
Member

miq-bot commented May 2, 2017

Checked commit https://github.com/CharlleDaniel/manageiq-ui-classic/commit/417b53b9c07776e89d307e02d8652f7e6904597a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@CharlleDaniel CharlleDaniel changed the title [WIP] Add network data in physical server details table [WIP] Add network data in physical server page May 2, 2017
@CharlleDaniel CharlleDaniel changed the title [WIP] Add network data in physical server page Add network data in physical server page May 2, 2017
@miq-bot miq-bot removed the wip label May 2, 2017
= render :partial => "layouts/flash_msg"
.row
.col-md-12.col-lg-6
= render :partial => "shared/summary/textual", :locals => {:title => _("Properties"), :items => textual_group_properties}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how it is done any more. Please, see #274 that includes many examples on how to define the groups.

@miq-bot
Copy link
Member

miq-bot commented May 3, 2017

This pull request is not mergeable. Please rebase and repush.

@CharlleDaniel CharlleDaniel deleted the add_network_data_in_server_detail_table branch May 4, 2017 14:34
@CharlleDaniel CharlleDaniel restored the add_network_data_in_server_detail_table branch May 4, 2017 14:51
@CharlleDaniel CharlleDaniel deleted the add_network_data_in_server_detail_table branch May 4, 2017 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants