Split ci_processing into smaller parts.

[martinpovolny]

Splitting methods into modules. Each module includes code specific for a
single button action.

[miq-bot]

Checked commit martinpovolny@3277616 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
10 files checked, 86 offenses detected

app/controllers/mixins/actions/vm_actions/associate_floating_ip.rb

• ❗ - Line 26, Col 77 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 35, Col 11 - Style/MultilineIfModifier - Favor a normal unless-statement over a modifier clause in a multiline statement.
• ❗ - Line 71, Col 43 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 76, Col 66 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 81, Col 79 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.

app/controllers/mixins/actions/vm_actions/disassociate_floating_ip.rb

• ❗ - Line 26, Col 80 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 34, Col 23 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.
• ❗ - Line 35, Col 11 - Style/MultilineIfModifier - Favor a normal unless-statement over a modifier clause in a multiline statement.
• ❗ - Line 73, Col 43 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 78, Col 66 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 83, Col 82 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.

app/controllers/mixins/actions/vm_actions/evacuate.rb

• ❗ - Line 7, Col 23 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.
• ❗ - Line 8, Col 65 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 8, Col 67 - Style/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 97, Col 1 - Style/TrailingBlankLines - 1 trailing blank lines detected.

app/controllers/mixins/actions/vm_actions/live_migrate.rb

• ❗ - Line 22, Col 69 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 22, Col 71 - Style/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 99, Col 1 - Style/TrailingBlankLines - 1 trailing blank lines detected.

app/controllers/mixins/actions/vm_actions/ownership.rb

• ❗ - Line 15, Col 70 - Style/WordArray - Use %w or %W for an array of words.
• ❗ - Line 178, Col 32 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.
• ❗ - Line 17, Col 30 - Style/WordArray - Use %w or %W for an array of words.
• ❗ - Line 187, Col 13 - Style/UnlessElse - Do not use unless with else. Rewrite these with the positive case first.
• ❗ - Line 25, Col 11 - Style/ConditionalAssignment - Use the return of the conditional for variable assignment and comparison.
• ❗ - Line 35, Col 14 - Style/ZeroLengthPredicate - Use empty? instead of length < 1.
• ❗ - Line 37, Col 110 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 56, Col 13 - Style/IfInsideElse - Convert if nested inside else to elsif.
• ❗ - Line 65, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 66, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 67, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 68, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 99, Col 29 - Style/MutableConstant - Freeze mutable objects assigned to constants.

app/controllers/mixins/actions/vm_actions/reconfigure.rb

• ⚠️ - Line 102, Col 11 - Lint/UselessAssignment - Useless assignment to variable - request_data.
• ❗ - Line 126, Col 14 - Style/ZeroLengthPredicate - Use empty? instead of length < 1.
• ❗ - Line 148, Col 37 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 151, Col 13 - Style/IfInsideElse - Convert if nested inside else to elsif.
• ❗ - Line 159, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 160, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 161, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 162, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 164, Col 13 - Style/AccessorMethodName - Do not prefix reader method names with get_.
• ❗ - Line 18, Col 29 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 18, Col 32 - Style/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 190, Col 20 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.
• ❗ - Line 192, Col 156 - Style/SpaceAfterComma - Space missing after comma.
• ❗ - Line 19, Col 135 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 242, Col 42 - Style/DoubleNegation - Avoid the use of double negation (!!).
• ❗ - Line 242, Col 78 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 243, Col 122 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 243, Col 40 - Style/DoubleNegation - Avoid the use of double negation (!!).
• ❗ - Line 243, Col 52 - Style/SpaceInsideParens - Space inside parentheses detected.
• ❗ - Line 250, Col 36 - Style/NumericPredicate - Use (mbsize.to_i % 1024).zero? instead of mbsize.to_i % 1024 == 0.
• ❗ - Line 257, Col 13 - Style/AccessorMethodName - Do not prefix reader method names with get_.
• ❗ - Line 295, Col 1 - Style/EmptyLinesAroundModuleBody - Extra empty line detected at module body end.
• ❗ - Line 40, Col 87 - Style/NestedTernaryOperator - Ternary operators must not be nested. Prefer if or else constructs instead.
• ❗ - Line 45, Col 25 - Style/NumericPredicate - Use (params[:cores_per_socket_count]).zero? instead of params[:cores_per_socket_count] == 0.
• ❗ - Line 46, Col 26 - Style/NumericPredicate - Use (params[:socket_count]).zero? instead of params[:socket_count] == 0.
• ❗ - Line 52, Col 36 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• ❗ - Line 52, Col 36 - Style/SpaceBeforeBlockBraces - Space missing to the left of {.
• ❗ - Line 54, Col 21 - Style/CaseIndentation - Indent when as deep as case.
• ❗ - Line 56, Col 21 - Style/CaseIndentation - Indent when as deep as case.
• ❗ - Line 60, Col 23 - Style/BlockEndNewline - Expression at 60, 23 should be on its own line.
• ❗ - Line 67, Col 36 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• ❗ - Line 67, Col 36 - Style/SpaceBeforeBlockBraces - Space missing to the left of {.
• ❗ - Line 75, Col 23 - Style/BlockEndNewline - Expression at 75, 23 should be on its own line.
• ❗ - Line 80, Col 13 - Style/SpaceAroundKeyword - Space after keyword if is missing.

app/controllers/mixins/actions/vm_actions/resize.rb

• ❗ - Line 21, Col 63 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 49, Col 79 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 62, Col 45 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 67, Col 67 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 73, Col 65 - Style/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 85, Col 11 - Style/RedundantReturn - Redundant return detected.

app/controllers/mixins/actions/vm_actions/retire.rb

• ❗ - Line 108, Col 17 - Style/ConditionalAssignment - Use the return of the conditional for variable assignment and comparison.
• ❗ - Line 129, Col 30 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 132, Col 35 - Style/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 152, Col 1 - Style/TrailingBlankLines - 1 trailing blank lines detected.
• ❗ - Line 34, Col 11 - Style/IndentationWidth - Use 2 (not 4) spaces for indentation.
• ❗ - Line 52, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 53, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 54, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 71, Col 17 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.
• ❗ - Line 98, Col 17 - Style/ConditionalAssignment - Use the return of the conditional for variable assignment and comparison.

app/controllers/mixins/actions/vm_actions/right_size.rb

• ❗ - Line 10, Col 14 - Style/ZeroLengthPredicate - Use empty? instead of length < 1.
• ❗ - Line 17, Col 13 - Style/IfInsideElse - Convert if nested inside else to elsif.
• ❗ - Line 29, Col 13 - Style/IfInsideElse - Convert if nested inside else to elsif.
• ❗ - Line 37, Col 9 - Style/Alias - Use alias instead of alias_method in a module body.
• ❗ - Line 42, Col 1 - Style/TrailingBlankLines - 1 trailing blank lines detected.