Added "Escalate Privilege" checkbox #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h-kataria For retirement Escalate Privilege option should be hidden or disabled if no playbook is selected. |
h-kataria
force-pushed
the
escalate_privilege_option
branch
from
8f75bb9
to
e0e6673
Compare
|
@bzwei please re-review |
h-kataria
force-pushed
the
escalate_privilege_option
branch
2 times, most recently
from
9aabe1a
to
6acd19a
Compare
Added "Escalate Privilege" checkbox switch on both Provisioning & Retirement tabs in form and on Summary screen to display the selected values. Default value for the new checkbox is false. https://bugzilla.redhat.com/show_bug.cgi?id=1445377
h-kataria
force-pushed
the
escalate_privilege_option
branch
from
6acd19a
to
7523a3a
Compare
|
Checked commit h-kataria@7523a3a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Tested and works! |
simaishi
pushed a commit
that referenced
this pull request
May 1, 2017
Added "Escalate Privilege" checkbox (cherry picked from commit 4f45c53) https://bugzilla.redhat.com/show_bug.cgi?id=1447086
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "Escalate Privilege" checkbox switch on both Provisioning & Retirement tabs in form and on Summary screen to display the selected values. Default value for the new checkbox is false.
https://bugzilla.redhat.com/show_bug.cgi?id=1445377
@gmcculloug @bzwei please review/test.
backend work in ManageIQ/manageiq#14929
screenshot:
