Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced search bar ansible tower fix #1209

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented May 1, 2017

Display the advanced bar on list pages in Ansible Tower and not on summary pages.

https://bugzilla.redhat.com/show_bug.cgi?id=1395744

To reproduce:
1.Open a tower provider summary
2.Select the Job Templates accordion
3. Go to Compute->Cloud->Providers
4. Return to Tower->Explorer

EUWE - a separate PR will be created for it.

@lgalis lgalis force-pushed the advanced_search_bar_ansible_tower_fix branch from 3f0d591 to ae513eb Compare May 1, 2017 16:14
@miq-bot miq-bot added the wip label May 1, 2017
@lgalis lgalis force-pushed the advanced_search_bar_ansible_tower_fix branch from 9d80dd7 to ec7a444 Compare May 1, 2017 18:17
@lgalis lgalis force-pushed the advanced_search_bar_ansible_tower_fix branch from ec7a444 to 3875fb8 Compare May 1, 2017 19:00
@miq-bot
Copy link
Member

miq-bot commented May 1, 2017

Checked commits lgalis/manageiq-ui-classic@0615fe5~...3875fb8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

@lgalis
Copy link
Contributor Author

lgalis commented May 1, 2017

@miq-bot add_label bug, fine/yes, euwe/no, blocker

@lgalis
Copy link
Contributor Author

lgalis commented May 1, 2017

@miq-bot remove_label wip

@lgalis
Copy link
Contributor Author

lgalis commented May 1, 2017

@dclarizio - please review

@miq-bot miq-bot changed the title [WIP] Advanced search bar ansible tower fix Advanced search bar ansible tower fix May 1, 2017
@miq-bot miq-bot removed the wip label May 1, 2017
@dclarizio dclarizio self-assigned this May 1, 2017
@dclarizio dclarizio merged commit afcaff5 into ManageIQ:master May 1, 2017
@dclarizio dclarizio added this to the Sprint 60 Ending May 8, 2017 milestone May 1, 2017
simaishi pushed a commit that referenced this pull request May 1, 2017
@simaishi
Copy link
Contributor

simaishi commented May 1, 2017

Fine backport details:

$ git log -1
commit 4ae4bcfef4e11bdfc60a28082a4b1156b317d5af
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon May 1 13:29:38 2017 -0700

    Merge pull request #1209 from lgalis/advanced_search_bar_ansible_tower_fix
    
    Advanced search bar ansible tower fix
    (cherry picked from commit afcaff574707cde65189921e58c568aba8153423)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447126

@lgalis
Copy link
Contributor Author

lgalis commented May 12, 2017

@miq-bot add_label euwe/yes
@miq-bot remove_label euwe/no

@miq-bot miq-bot added euwe/yes and removed euwe/no labels May 12, 2017
@simaishi
Copy link
Contributor

@lgalis marking as conflict for now, please remove the label when you have Euwe PR. Thanks!

@lgalis
Copy link
Contributor Author

lgalis commented May 25, 2017

Euwe branch was fixed by this PR: ManageIQ/manageiq#12719.
Removing the euwe labels.
@miq-bot add_label euwe/no
@miq-bot remove_label euwe/yes, euwe/conflict

@miq-bot miq-bot added euwe/no and removed euwe/yes labels May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants