New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fail if the method is not defined on the topology graph #1221
Conversation
Checked commit jkremser@c1a1213 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miq-bot add_label topology |
@Jiri-Kremser This part of the code was refactored in #1171, which is |
@Fryguy , I'd rather create a different darga PR, give me a sec. |
Conflict resolver PR for ManageIQ#1221
@skateman thanks for the PR π , I was already afk |
Backported to Fine via #1226 |
This is a hot-fix for https://bugzilla.redhat.com/show_bug.cgi?id=1446822
Before: πΉ π’ βοΈ
After: π¦ π βοΈ
If the model/relationships for topology graph is not specified well it might fail with this error:
Let's make it more robust.
@miq-bot assign @skateman
@miq_bot add_label bug, topology, blocker
/cc @abonas @theute