Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating IP related crosslinks for load balancers #1232

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented May 3, 2017

Depends on:

Floating IP related crosslinks for load balancers, namely
floating_ips, networks_ports and security_groups.

Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1387616

Floating IP related crosslinks for load balancers, namely
floating_ips, networks_ports and security_groups.

Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1387616
@Ladas
Copy link
Contributor Author

Ladas commented May 3, 2017

@miq-bot assign @martinpovolny

@Ladas
Copy link
Contributor Author

Ladas commented May 3, 2017

before:
screenshot from 2017-05-03 10-39-27
screenshot from 2017-05-03 10-51-54
screenshot from 2017-05-03 10-51-43
screenshot from 2017-05-03 10-51-38

after:
screenshot from 2017-05-03 10-46-51
screenshot from 2017-05-03 09-48-02
screenshot from 2017-05-03 09-47-55
screenshot from 2017-05-03 09-47-46
screenshot from 2017-05-03 09-47-36
screenshot from 2017-05-03 09-47-06
screenshot from 2017-05-03 10-48-25

@Ladas Ladas closed this May 3, 2017
@Ladas Ladas reopened this May 3, 2017
@martinpovolny
Copy link

@Ladas : looks great!

Please, fix the 2 robocop issues and we can merge this.

Thx!

Fix rubocop issues
@miq-bot
Copy link
Member

miq-bot commented May 4, 2017

Checked commits Ladas/manageiq-ui-classic@35dbd79~...12796a2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks fine. 🍰

@martinpovolny martinpovolny merged commit faa2eb5 into ManageIQ:master May 4, 2017
@martinpovolny martinpovolny added this to the Sprint 60 Ending May 8, 2017 milestone May 4, 2017
@simaishi simaishi removed the euwe/yes label May 11, 2017
simaishi pushed a commit that referenced this pull request Jun 6, 2017
…r_load_balancers

Floating IP related crosslinks for load balancers
(cherry picked from commit faa2eb5)

https://bugzilla.redhat.com/show_bug.cgi?id=1458943
@simaishi
Copy link
Contributor

simaishi commented Jun 6, 2017

Fine backport details:

$ git log -1
commit e157c3660a9ae83e48265d4540321b270b6978b3
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu May 4 08:46:10 2017 +0200

    Merge pull request #1232 from Ladas/floating_ip_related_crosslinks_for_load_balancers
    
    Floating IP related crosslinks for load balancers
    (cherry picked from commit faa2eb560b71c9fb01bcf655b1e86b9bfd5d9c25)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants