Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete duplicate flash message display in Optimize Planning page #1342

Merged
merged 1 commit into from May 18, 2017
Merged

Delete duplicate flash message display in Optimize Planning page #1342

merged 1 commit into from May 18, 2017

Conversation

GregP
Copy link
Contributor

@GregP GregP commented May 12, 2017

Display flash message only once when Reset button is clicked

https://bugzilla.redhat.com/show_bug.cgi?id=1381650

Screen shot before code fix:

optimize planning reset button click with 2 flash messages

Screen shot post code fix:

optimize planning reset button 1 message post code fix

@GregP
Copy link
Contributor Author

GregP commented May 12, 2017

@h-kataria Ready for review.

@miq-bot
Copy link
Member

miq-bot commented May 12, 2017

Checked commit GregP@fb64289 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/controllers/miq_capacity_controller.rb

@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 61 Ending May 22, 2017 milestone May 18, 2017
@h-kataria h-kataria merged commit c922477 into ManageIQ:master May 18, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 604983f3b2cb53ed902c884af3c256f3596bb04b
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed May 17 22:53:11 2017 -0400

    Merge pull request #1342 from GregP/optimize_planning_reset_flash_msg_display
    
    Delete duplicate flash message display in Optimize Planning page
    (cherry picked from commit c922477c6916d982e14bb929788c5b2dae13b106)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1454443

simaishi pushed a commit that referenced this pull request Jun 8, 2017
@h-kataria @simaishi
Merge pull request #1342 from GregP/optimize_planning_reset_flash_msg…
f7ebc76 
…_display

Delete duplicate flash message display in Optimize Planning page
(cherry picked from commit c922477)

https://bugzilla.redhat.com/show_bug.cgi?id=1459992
@simaishi
Copy link
Contributor

simaishi commented Jun 8, 2017

Fine backport details:

$ git log -1
commit f7ebc76904149dde2af7e427d3622debca6c6738
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed May 17 22:53:11 2017 -0400

    Merge pull request #1342 from GregP/optimize_planning_reset_flash_msg_display
    
    Delete duplicate flash message display in Optimize Planning page
    (cherry picked from commit c922477c6916d982e14bb929788c5b2dae13b106)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug euwe/backported fine/backported optimize
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GregP @miq-bot @h-kataria @simaishi @dclarizio