Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gtl buttons toolbar for automation manager when refreshed from hash #1410

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented May 22, 2017

Set gtl buttons toolbar for automation manager when refreshed from hash by using the browser refresh button.

https://bugzilla.redhat.com/show_bug.cgi?id=1452425

To reproduce the problem - navigate to Ansible Tower and select a provider - the inventory groups will be listed on the right. Then, click the refresh button for the browser, not the application. The gtl buttons are not displayed.

@lgalis
Copy link
Contributor Author

lgalis commented May 22, 2017

@miq-bot add_label bug, fine/yes

@lgalis lgalis force-pushed the automation_manager_x_gtl_toolbar_buttons_from_hash branch from 51e4ddd to a43ceff Compare May 24, 2017 17:49
@miq-bot
Copy link
Member

miq-bot commented May 24, 2017

Checked commits lgalis/manageiq-ui-classic@ef57ada~...a43ceff with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@lgalis
Copy link
Contributor Author

lgalis commented May 24, 2017

@h-kataria - please review

@lgalis lgalis changed the title [WIP] Set gtl buttons toolbar for automation manager when refreshed from hash Set gtl buttons toolbar for automation manager when refreshed from hash May 24, 2017
@miq-bot miq-bot removed the wip label May 24, 2017
@lgalis
Copy link
Contributor Author

lgalis commented May 25, 2017

@miq-bot assign h-kataria

@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 62 Ending Jun 5, 2017 milestone May 25, 2017
@h-kataria h-kataria merged commit 8b88045 into ManageIQ:master May 25, 2017
simaishi pushed a commit that referenced this pull request Jun 9, 2017
…_buttons_from_hash

Set gtl buttons toolbar for automation manager when refreshed from hash
(cherry picked from commit 8b88045)

https://bugzilla.redhat.com/show_bug.cgi?id=1460375
@simaishi
Copy link
Contributor

simaishi commented Jun 9, 2017

Fine backport details:

$ git log -1
commit 4b1d4c9abf8567f0329956d256c6395f12374e5d
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu May 25 13:23:38 2017 -0400

    Merge pull request #1410 from lgalis/automation_manager_x_gtl_toolbar_buttons_from_hash
    
    Set gtl buttons toolbar for automation manager when refreshed from hash
    (cherry picked from commit 8b88045cb049e59fb8d5193dd63c7927d441819b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants