Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rbac for network managers #1434

Merged
merged 3 commits into from May 25, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented May 25, 2017

  • use AR model to get the result
  • add RBAC

introduced in #1343

@miq-bot add_label rbac, technical-dept

@miq-bot assign @martinpovolny
cc @himdel

for example it is in:

screen shot 2017-05-25 at 15 11 32

Next (if you are not against)

  network_managers.each do |network_manager|
      @network_provider_choices[network_manager.name] = network_manager.id
    end

@miq-bot
Copy link
Member

miq-bot commented May 25, 2017

@lpichler Cannot apply the following label because they are not recognized: technical-dept

@miq-bot
Copy link
Member

miq-bot commented May 25, 2017

Checked commits lpichler/manageiq-ui-classic@6225a3d~...4986c5c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@dclarizio
Copy link

@lpichler can you recommend the fine and euwe labels? I'm not sure if they should follow the original bug fix PR that you reference in the first comment. If so, should probably reference that same BZ or maybe create a new one for this PR. Thx, Dan

@martinpovolny martinpovolny merged commit 9350335 into ManageIQ:master May 25, 2017
@martinpovolny martinpovolny added this to the Sprint 62 Ending Jun 5, 2017 milestone May 25, 2017
@lpichler lpichler deleted the add_rbac_for_network_managers branch May 31, 2017 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants