Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Providers text and Cluster info in host listnav #1471

Merged
merged 1 commit into from Jun 1, 2017

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented May 31, 2017

The Host listnav had some inconsistencies with how the data was displayed in the Summary screen.

  • Fixed the Providers text to display Infrastructure Provider
  • Ensured that Cluster: None text (minus the link) is displayed in the listnav when the host does not have a cluser record associated with it

Before:
screen shot 2017-05-31 at 3 35 15 pm

After:
screen shot 2017-05-31 at 3 23 33 pm

https://bugzilla.redhat.com/show_bug.cgi?id=1457934

@AparnaKarve
Copy link
Contributor Author

/cc @dclarizio

@miq-bot
Copy link
Member

miq-bot commented May 31, 2017

Checked commit AparnaKarve@9c376dd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Jun 1, 2017
@mzazrivec mzazrivec added this to the Sprint 62 Ending Jun 5, 2017 milestone Jun 1, 2017
@mzazrivec mzazrivec merged commit fa2a46d into ManageIQ:master Jun 1, 2017
@AparnaKarve
Copy link
Contributor Author

@miq-bot remove_label "bugzilla needed"

@miq-bot
Copy link
Member

miq-bot commented Jun 1, 2017

@AparnaKarve Cannot remove the following label because they are not recognized: "bugzilla needed"

simaishi pushed a commit that referenced this pull request Jun 12, 2017
Fix Providers text and Cluster info in host listnav
(cherry picked from commit fa2a46d)

https://bugzilla.redhat.com/show_bug.cgi?id=1460777
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 2fb220b3e1b11cca9fb07ea7116ba6c8b2862a9c
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Jun 1 10:29:46 2017 +0200

    Merge pull request #1471 from AparnaKarve/fix_host_listnav
    
    Fix Providers text and Cluster info in host listnav
    (cherry picked from commit fa2a46d14b849f4cd646690accfcdf7044c0a80d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants