Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudSubnet: IP version not displayed #1515

Merged
merged 1 commit into from Jun 9, 2017
Merged

CloudSubnet: IP version not displayed #1515

merged 1 commit into from Jun 9, 2017

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jun 9, 2017 •
edited

Use network_protocol instead of ip_version which match CloudSubnet field name and allows to display the value properly in the edit view.

cloudsubnet_ip_version

https://bugzilla.redhat.com/show_bug.cgi?id=1460878

@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2017

@gildub Cannot apply the following label because they are not recognized: bug fine/yes euwe/yes

@miq-bot miq-bot added the bug label Jun 9, 2017
@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2017

@gildub Cannot apply the following label because they are not recognized: fine/yes euwe/yes

@gildub
Copy link
Contributor Author

gildub commented Jun 9, 2017

@dclarizio, there is no BZ because I just bumped into that one myself.

@gildub
CloudSubnet: IP version not displayed
7254e32 
Use `network_protocol` instead of `ip_version` which match CloudSubnet
field name and allows to display the value properly in the edit view.
@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2017

Checked commit https://github.com/gildub/manageiq-ui-classic/commit/7254e32060808d1633fafd1d0a59c471fb25a393 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 9, 2017
@mzazrivec mzazrivec merged commit 217a335 into ManageIQ:master Jun 9, 2017
@dclarizio dclarizio assigned mzazrivec and unassigned dclarizio Jun 9, 2017
@gildub gildub deleted the cloud_subnets-network_protocol-to-ip_version branch June 9, 2017 23:43
simaishi pushed a commit that referenced this pull request Jun 13, 2017
@mzazrivec @simaishi
Merge pull request #1515 from gildub/cloud_subnets-network_protocol-t…
cbc4be6 
…o-ip_version

CloudSubnet: IP version not displayed
(cherry picked from commit 217a335)

https://bugzilla.redhat.com/show_bug.cgi?id=1461070
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit cbc4be6464369e3a7fc6bfa15356e9528bd4e61d
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Jun 9 13:33:46 2017 +0200

    Merge pull request #1515 from gildub/cloud_subnets-network_protocol-to-ip_version
    
    CloudSubnet: IP version not displayed
    (cherry picked from commit 217a33558036e5e4bf39fe4daa9e1a9303b1c0d9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1461070

@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 8b962c238b709de2c974355a62ddf3a4f525f7cb
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Jun 9 13:33:46 2017 +0200

    Merge pull request #1515 from gildub/cloud_subnets-network_protocol-to-ip_version
    
    CloudSubnet: IP version not displayed
    (cherry picked from commit 217a33558036e5e4bf39fe4daa9e1a9303b1c0d9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1465080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug euwe/backported fine/backported networks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gildub @miq-bot @simaishi @dclarizio @mzazrivec