Support for Prometheus in Container Provider summary page #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrodshn
force-pushed
the
add_prometheus_endpoint_to_summary
branch
from
cb061e9
to
ca4c146
Compare
mzazrivec
suggested changes
Jun 13, 2017
| :value => @record.connection_configurations.hawkular.endpoint.port | ||
| } | ||
| {:label => _("#{e.role.capitalize} Host Name"), :value => e.hostname}, | ||
| {:label => _("#{e.role.capitalize} API Port"), :value => e.port} |
There was a problem hiding this comment.
#{e.role.capitalize} inside a gettext won't work. This needs to be (and other occurences):
_("%{role} Host Name") % {:role => e.role.capitalize}There was a problem hiding this comment.
@mzazrivec thnx a lot mate! 👍 fixed. 🐕
nimrodshn
changed the title
refactoring refactoring some refactoring
nimrodshn
force-pushed
the
add_prometheus_endpoint_to_summary
branch
from
ca4c146
to
1a69170
Compare
|
@mzazrivec thnx a lot mate! 👍 |
|
Checked commit nimrodshn@1a69170 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
nimrodshn
changed the title
mzazrivec
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Prometheus Endpoint in Container Provider summary page.
screenshot:
cc: @simon3z @yaacov @moolitayer