Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patternfly-timeline to 1.0.5 #1573

Merged
merged 1 commit into from Jun 22, 2017
Merged

Update patternfly-timeline to 1.0.5 #1573

merged 1 commit into from Jun 22, 2017

Conversation

epwinchell
Copy link
Contributor

This PR updates patternfly-timeline from 1.0.3 to 1.0.5, fixing an IE11 scrolling bug. This is the original PF PR: patternfly/patternfly-timeline#34

https://bugzilla.redhat.com/show_bug.cgi?id=1443511

@epwinchell
Copy link
Contributor Author

@miq-bot assign @bmclaughlin

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, fine/yes

@miq-bot
Copy link
Member

miq-bot commented Jun 20, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/2ed6a422df0535986c1fd77cdae3ff6d06c3e42b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@dclarizio dclarizio assigned h-kataria and unassigned bmclaughlin Jun 21, 2017
bmclaughlin
bmclaughlin approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@bmclaughlin bmclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timelines appear as expected.

@h-kataria h-kataria added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 22, 2017
@h-kataria h-kataria merged commit 4da95f8 into ManageIQ:master Jun 22, 2017
simaishi pushed a commit that referenced this pull request Aug 4, 2017
@h-kataria @simaishi
Merge pull request #1573 from epwinchell/patternfly_timeline_update
ad01b91 
Update patternfly-timeline to 1.0.5
(cherry picked from commit 4da95f8)

https://bugzilla.redhat.com/show_bug.cgi?id=1478388
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit ad01b9127587484579d116934ee1acb8990012b9
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Jun 22 11:32:47 2017 -0400

    Merge pull request #1573 from epwinchell/patternfly_timeline_update
    
    Update patternfly-timeline to 1.0.5
    (cherry picked from commit 4da95f89a6532d50726dd3e4e4261fadc7d44fea)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478388

@epwinchell epwinchell deleted the patternfly_timeline_update branch October 25, 2017 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmclaughlin bmclaughlin bmclaughlin approved these changes

Assignees

@h-kataria h-kataria

Labels
bug fine/backported timelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@epwinchell @miq-bot @simaishi @bmclaughlin @dclarizio @h-kataria