app: Redirect to cockpit #1649
Merged
app: Redirect to cockpit #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervo
force-pushed
the
cockpit-ws
branch
2 times, most recently
from
a59f7da
to
03422f2
Compare
|
@mzazrivec so making a new PR seems to have helped. The current failures seem to be present in other PRs as well. Is this a just keep trying situation? Or is there a known good commit I should base off of? |
Redirects the user to cockpit including a valid API token as a url fragment so that cockpit can validate the current user.
|
Checked commit petervo@ff78ac6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@petervo we are having some travis failures right now, but are working to correct them. Basing on a different commit won't help as travis does a dynamic rebase off master before running the tests. Once the tests are fixed, we can restart your tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirects the user to cockpit including a valid API token as a url fragment so that cockpit can validate the
current user.
Split from ManageIQ/manageiq#12506 post UI refactoring.