Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update variable used for header border color #1653

Merged
merged 1 commit into from Jul 5, 2017
Merged

update variable used for header border color #1653

merged 1 commit into from Jul 5, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Jul 5, 2017 •
edited

This PR updates the variable used for overriding the header border color. (The variable was changed with the introduction of vertical navigation.)

https://bugzilla.redhat.com/show_bug.cgi?id=1467968

Old
screen shot 2017-07-05 at 12 37 10 pm

New
screen shot 2017-07-05 at 12 36 34 pm

@miq-bot
Copy link
Member

miq-bot commented Jul 5, 2017

@epwinchell unrecognized command 'bug', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, formatting/styling

@miq-bot
Copy link
Member

miq-bot commented Jul 5, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/8ca066d805604eaa162a8e55872ce05dce8360bb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@epwinchell
Copy link
Contributor Author

@miq-bot add_label fine/yes, euwe/yes

@epwinchell epwinchell closed this Jul 5, 2017
@epwinchell epwinchell reopened this Jul 5, 2017
@dclarizio
Copy link

Test failures are completely unrelated, merging.

@dclarizio dclarizio merged commit e7cb712 into ManageIQ:master Jul 5, 2017
@dclarizio dclarizio added this to the Sprint 64 Ending Jul 10, 2017 milestone Jul 5, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 2d6760e4c79000adf3a6f7d4a1dc85b5cbcddfcf
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Jul 5 13:16:17 2017 -0700

    Merge pull request #1653 from epwinchell/header_border-color
    
    update variable used for header border color
    (cherry picked from commit e7cb7123d5e6223d456c3274262588123366be3c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1472364

simaishi pushed a commit that referenced this pull request Aug 4, 2017
@simaishi
Merge pull request #1653 from epwinchell/header_border-color
922305a 
update variable used for header border color
(cherry picked from commit e7cb712)

https://bugzilla.redhat.com/show_bug.cgi?id=1478523
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport details:

$ git log -1
commit 922305af390a1d48d8444ccd961eb480bee477de
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Wed Jul 5 13:16:17 2017 -0700

    Merge pull request #1653 from epwinchell/header_border-color
    
    update variable used for header border color
    (cherry picked from commit e7cb7123d5e6223d456c3274262588123366be3c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478523

@epwinchell epwinchell deleted the header_border-color branch October 25, 2017 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug euwe/backported fine/backported formatting/styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@epwinchell @miq-bot @dclarizio @simaishi