Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix missing constant in application_controller" #1692

Merged
merged 1 commit into from Jul 14, 2017
Merged

Revert "Fix missing constant in application_controller" #1692

merged 1 commit into from Jul 14, 2017

Conversation

martinpovolny
Copy link

@miq-bot
Copy link
Member

miq-bot commented Jul 14, 2017

Some comments on commit d39c556

app/controllers/miq_task_controller.rb

  • ⚠️ - 191 - Detected pp. Remove all debugging statements.
  • ⚠️ - 37 - Detected pp. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Jul 14, 2017

Checked commit d39c556 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 2 offenses detected

app/controllers/miq_task_controller.rb

NickLaMuro
NickLaMuro approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@NickLaMuro NickLaMuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@mzazrivec mzazrivec self-assigned this Jul 14, 2017
@mzazrivec mzazrivec mentioned this pull request Jul 14, 2017
Closed
@mzazrivec mzazrivec added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 14, 2017
@mzazrivec mzazrivec merged commit 25daac0 into master Jul 14, 2017
@Fryguy Fryguy deleted the revert-1673-bugs/missing_ppcchoices branch October 3, 2017 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLaMuro NickLaMuro NickLaMuro approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug dashboards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martinpovolny @miq-bot @NickLaMuro @mzazrivec