Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide firmware table if there are no firmware entries #1694

Merged
merged 1 commit into from Jul 17, 2017

Conversation

skovic
Copy link

@skovic skovic commented Jul 14, 2017

Updated the code so that the firmware table on the physical server summary page is only displayed when there are firmware entries. Without this change, only the firmware table's headers are displayed when no firmware entries are present which may be confusing to users.

@miq-bot
Copy link
Member

miq-bot commented Jul 14, 2017

Checked commit skovic@9193a75 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Jul 17, 2017
@mzazrivec mzazrivec added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 17, 2017
@mzazrivec mzazrivec merged commit e05fc34 into ManageIQ:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants