Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Power actions for Instances in Orchestration Stack page #1696

Merged
merged 1 commit into from Jul 24, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Jul 17, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1397912

Compute -> Clouds -> Stacks -> click any Stack with Instances -> click Instances -> check one or more Instances -> Power -> choose any action

Before it took Stacks id and klass for Power action instead of selected instance(s).

Before:
screen shot 2017-07-17 at 1 06 02 pm

After:
screen shot 2017-07-17 at 1 08 53 pm

@miq-bot add_label bug

@h-kataria please review, thanks :)

@miq-bot miq-bot added the bug label Jul 17, 2017
@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2017

Checked commit ZitaNemeckova@7c9cea9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 24, 2017
@h-kataria h-kataria merged commit ea9f54c into ManageIQ:master Jul 24, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit e0a9ea8039d6e9c802955f16c1689ccd1f2a5a71
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Jul 24 15:41:20 2017 -0400

    Merge pull request #1696 from ZitaNemeckova/instance_action_fix
    
    Fix Power actions for Instances in Orchestration Stack page
    (cherry picked from commit ea9f54cdeef0b7cd68ef549e0053fe24463b45fd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1476296

simaishi pushed a commit that referenced this pull request Aug 9, 2017
Fix Power actions for Instances in Orchestration Stack page
(cherry picked from commit ea9f54c)

https://bugzilla.redhat.com/show_bug.cgi?id=1479927
@simaishi
Copy link
Contributor

simaishi commented Aug 9, 2017

Fine backport details:

$ git log -1
commit de9ecc7d79627e92ab62110d2b4648048a86afa3
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Jul 24 15:41:20 2017 -0400

    Merge pull request #1696 from ZitaNemeckova/instance_action_fix
    
    Fix Power actions for Instances in Orchestration Stack page
    (cherry picked from commit ea9f54cdeef0b7cd68ef549e0053fe24463b45fd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1479927

@ZitaNemeckova ZitaNemeckova deleted the instance_action_fix branch September 12, 2017 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants