Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Objects UI #1724

Merged
merged 5 commits into from Jul 26, 2017
Merged

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Jul 19, 2017

This is the first of the many PRs for Generic Objects UI.

(To be considered for a merge after the Product Features PR: ManageIQ/manageiq#15611 has been merged)

Contains -

  • Generic Objects menu item now visible to the user
  • Basic show_list (deletes the existing explorer view)
  • Basic show
  • spec for show_list and show

Generic Objects Menu:
screen shot 2017-07-19 at 4 28 06 pm

Generic Object Classes show_list:
screen shot 2017-07-19 at 4 27 04 pm

Generic Object Classes show:
screen shot 2017-07-19 at 4 29 47 pm

@miq-bot miq-bot added the wip label Jul 19, 2017
@AparnaKarve AparnaKarve force-pushed the generic_object_ui branch 2 times, most recently from e0352d4 to d7fe183 Compare July 21, 2017 22:04
@AparnaKarve
Copy link
Contributor Author

@miq-bot remove_label wip

@AparnaKarve
Copy link
Contributor Author

@martinpovolny Please review.

@miq-bot miq-bot changed the title [WIP] Generic Objects UI Generic Objects UI Jul 21, 2017
@miq-bot miq-bot removed the wip label Jul 21, 2017
@miq-bot
Copy link
Member

miq-bot commented Jul 21, 2017

Checked commits AparnaKarve/manageiq-ui-classic@d84e707~...773fa67 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 2 offenses detected

app/controllers/generic_object_definition_controller.rb

@AparnaKarve
Copy link
Contributor Author

@martinpovolny Can we get this merged soon?
There are other PRs in the pipeline waiting for this to be merged. Thanks.

@dclarizio
Copy link

@martinpovolny need this reviewed as it is phase 1 of the new generic objects UI for the G release. @AparnaKarve tried to follow the existing templates as best she could, but definitely look this over as generic objects are somewhat different than other active record objects. Thx, Dan

@martinpovolny martinpovolny added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 26, 2017
@martinpovolny martinpovolny merged commit 9ee2310 into ManageIQ:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants