Optional chargeback allocated calculation #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
optionable_allocated_calculation_ui
branch
from
4a6865f
to
3571b4f
Compare
mzazrivec
reviewed
Jul 31, 2017
| @@ -1295,6 +1299,7 @@ def set_form_vars | |||
|
|
|||
| # @edit[:new][:cb_include_metrics] = nil - it means YES (YES is default value for new and legacy reports) | |||
| @edit[:new][:cb_include_metrics] = options[:include_metrics].nil? || options[:include_metrics] | |||
| @edit[:new][:method_for_allocated_metrics] = options[:method_for_allocated_metrics].try(:to_sym) || DEFAULT_CHARGEBACK_ALLOCATED_METHOD | |||
There was a problem hiding this comment.
_() needs to be applied to the values of the CHAREGEBACK_ALLOCATED_METHODS hash for i18n
to really work here (same in the rest of this PR).
lpichler
force-pushed
the
optionable_allocated_calculation_ui
branch
from
3571b4f
to
d37a04f
Compare
|
Checked commits lpichler/manageiq-ui-classic@f5a4bcc~...d37a04f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/report_controller/reports/editor.rb
app/helpers/ui_constants.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the parameter to report definition to be able to select another method for chargeback calculation.
Links
cc @gtanzillo
@miq-bot assign @himdel
@miq_bot add_label enhancement