Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full screen button for Firefox in remote consoles #1743

Merged

Conversation

bmclaughlin
Copy link
Contributor

@miq-bot add_labels compute/infrastructure, compute/cloud, fine/yes

https://bugzilla.redhat.com/show_bug.cgi?id=1454912

@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2017

Checked commit bmclaughlin@e6456b4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 27, 2017
@martinpovolny martinpovolny merged commit 4f1c4ec into ManageIQ:master Jul 27, 2017
@bmclaughlin bmclaughlin deleted the vnc-console-firefox-fullscreen-btn branch July 27, 2017 11:26
simaishi pushed a commit that referenced this pull request Aug 9, 2017
…een-btn

Fix full screen button for Firefox in remote consoles
(cherry picked from commit 4f1c4ec)

https://bugzilla.redhat.com/show_bug.cgi?id=1479935
@simaishi
Copy link
Contributor

simaishi commented Aug 9, 2017

Fine backport details:

$ git log -1
commit ae460cdcb77fa85d02867427cb92b7052ab6a43d
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Jul 27 10:23:54 2017 +0200

    Merge pull request #1743 from bmclaughlin/vnc-console-firefox-fullscreen-btn
    
    Fix full screen button for Firefox in remote consoles
    (cherry picked from commit 4f1c4ec52c6834820da1d976ce13ace4052af5bf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1479935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants