Fix HAML indentation for Report Widget fragment #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing indentation caused the widget content being outisde of the div.mc which handles minimizing, therefore minimizing and maximizing of the widget did not work. https://bugzilla.redhat.com/show_bug.cgi?id=1476305
|
Checked commit https://github.com/mfalesni/manageiq-ui-classic/commit/1f589f5d1fd93798d77f9ab644460631e8afad8f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/dashboard/_widget_report.html.haml
|
|
Verified in UI. |
simaishi
pushed a commit
that referenced
this pull request
Aug 11, 2017
Fix HAML indentation for Report Widget fragment (cherry picked from commit 3b53934) https://bugzilla.redhat.com/show_bug.cgi?id=1480589
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing indentation caused the widget content being outside of the div.mc which handles minimizing, therefore minimizing and maximizing of the widget did not work.
https://bugzilla.redhat.com/show_bug.cgi?id=1476305