Use the fonticon picker component to pick custom button icons #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
reviewed
Aug 2, 2017
| var vm = this; | ||
| // This is an ugly hack to be able to use this component in a non-angular context with miq-observe | ||
| // FIXME: Remove this when the form is converted to angular | ||
| var hidden = $($element[0]).find('input[type="hidden"]'); |
There was a problem hiding this comment.
$element.find should work too?
There was a problem hiding this comment.
I made this code the ugliest as possible on purpose so no one will forget to remove it when converting the form to Angular.
himdel
reviewed
Aug 2, 2017
| @@ -0,0 +1,18 @@ | |||
| /* global add_flash */ | |||
| (function() { | |||
| var COTNROLLER_NAME = 'fonticonPickerController'; | |||
skateman
force-pushed
the
fonticon-picker
branch
from
b8f5f77
to
246f1eb
Compare
skateman
force-pushed
the
fonticon-picker
branch
from
246f1eb
to
501f7e2
Compare
|
Checked commit skateman@501f7e2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Tested in the UI, looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I included the angular component in the non-angular form is an ugly hack and should not be used as an example. After the form is converted to angular, it should be removed.
Depends on: ManageIQ/ui-components#105
Pivotal story: https://www.pivotaltracker.com/story/show/147779325
@epwinchell @himdel @karelhala