Reset selected snapshot in session when deleting the snapshot #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@h-kataria please review. |
h-kataria
reviewed
Jan 23, 2017
| @@ -1874,6 +1874,12 @@ def vm_button_operation(method, display_name, partial_after_single_selection = n | |||
| @single_delete = true unless flash_errors? | |||
| end | |||
|
|
|||
| # Reset session[:snap_selected] if that snapshot is being deleted | |||
| if method == 'remove_snapshot' && session[:snap_selected].present? && | |||
| Snapshot.find(session[:snap_selected]).vm_or_template_id.to_s == params[:id] | |||
There was a problem hiding this comment.
@bmclaughlin can't we just check for existence of Snapshot record here like this: Snapshot.find_by_id(session[:snap_selected]).nil?
|
@h-kataria, ready for another review. |
|
@bmclaughlin your PR solves #209 as well :) |
bmclaughlin
force-pushed
the
reset-snapshot-in-session
branch
from
06981ed
to
636ea9f
Compare
|
changes looks good. |
bmclaughlin
force-pushed
the
reset-snapshot-in-session
branch
from
636ea9f
to
7962ae0
Compare
|
Checked commits bmclaughlin/manageiq-ui-classic@722bd2c~...7962ae0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@bmclaughlin There is a conflict in backporting to Euwe for the spec file. Can you create an Euwe PR? |
|
Backported to Euwe via ManageIQ/manageiq#14361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error in the logs and the page not loading when the currently selected snapshot is deleted and attempting to view the Snapshot Summary page.
Closes #209
https://bugzilla.redhat.com/show_bug.cgi?id=1395116