Hide History toolbar when in Reports Import/Export tree #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h-kataria Ready for review. |
h-kataria
suggested changes
Aug 15, 2017
app/controllers/report_controller.rb
Outdated
| @@ -687,7 +687,7 @@ def replace_right_cell(options = {}) # :replace_trees key can be an array of tr | |||
| partial = options[:partial] ? options[:partial] : set_partial_name | |||
| unless @in_a_form | |||
| c_tb = build_toolbar(center_toolbar_filename) | |||
| h_tb = build_toolbar("x_history_tb") | |||
| h_tb = build_toolbar("x_history_tb") unless (x_active_tree == "export_tree" || params[:id] == "export_accord") | |||
There was a problem hiding this comment.
@GregP please change check to unless x_active_tree == :export_tree that should be good enough, value of x_active_tree is a symbol not string
GregP
force-pushed
the
hide_history_tb_report_export
branch
from
5033cd1
to
b9afb5c
Compare
|
Checked commit GregP@b9afb5c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
h-kataria
approved these changes
Aug 15, 2017
|
looks good. |
simaishi
pushed a commit
that referenced
this pull request
Aug 15, 2017
Hide History toolbar when in Reports Import/Export tree (cherry picked from commit b7bf129) https://bugzilla.redhat.com/show_bug.cgi?id=1481853
|
Fine backport details: |
|
@h-kataria Would it be ok to backport this to Euwe branch? |
|
@simaishi yes, good to be be backported to EUWE |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not display History Toolbar when in Reports => Import / Export tree, no history to be available/selected.
https://bugzilla.redhat.com/show_bug.cgi?id=1393193
Screen shot prior to fix:
===================
Screen shots post fix: