Change webpacker to store plugin javascript in corespoding folder

[karelhala]

when webpacker loads files it will store them in plugin's folder in public/packs folder.

Before

Folder structure of public packs was

public/packs/hello_angular.js
public/packs/application.js
public/packs/manifest.json

Usage in haml file:

+%hello-angular
+  Loading...
+= javascript_pack_tag 'hello_angular'

After

Folder structure of public packs

public/packs/manageiq-ui-classic/hello_angular.js
public/packs/manageiq-ui-classic/application.js
public/packs/manifest.json

Usage in haml file:

+%hello-angular
+  Loading...
+= javascript_pack_tag 'manageiq-ui-classic/hello_angular'

Fixes plugin's javascripts

If we were to add another plugin with app/javascript/packs/example.js the chunk name was broken ../../plugin_example/app/javascript/packs/example, this file was later on not accessible and threw 404. This PR changes it that any JS packs will be copied over to parent manageIq core public/packs folder and will be placed within folder of plugin's name. (for example)

plugin_example/example.js

Usage of such JS is (can be used across whole MiQ app, not just in plugin):

+= javascript_pack_tag 'plugin_example/example'

[karelhala]

@miq-bot assign @himdel
@miq-bot add_label bug, enhancement

Can someone else look at it and check if it's ok? perhaps @mtho11 @ohadlevy @h-kataria

[miq-bot]

Checked commits karelhala/manageiq-ui-classic@cad5591~...05003f3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

[himdel]

LGTM 👍 pretty much just waiting for feedback if any, and travis :)

[himdel]

Merged :)

Cc @mtho11 @ohadlevy - this will break your dev branches

[mtho11]

@himdel ok thanks!

[NickLaMuro]

@himdel @karelhala This breaks when installed as a manageiq-ui-classic is installed as a git gem because the directory looks something like manageiq-ui-classic-COMMIT-SHA-HERE when bundler installs, and there is basedir logic in the config/webpack/shared.js, but hard coded paths in the layout file.

This passed when you tested this locally, it most likely was with you using override_gem, which won't have this problem, unless you cloned it to something like manageiq-ui-classic-local. In that case, it probably would have broke.

I am partially bringing this up because this is the second time in the past week where this has happened (bug passed in local testing, but failed in the "git gem" scenario). Can we look at ways of somehow testing this in it's git gem form prior to merging? This will most likely happen again in the future, and it would be nice if it was preventable before affecting others (currently breaking appliance/docker builds based off of master).

[NickLaMuro]

My above comment should be addressed in #1925