Fix pdf download for configuration profiles #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
force-pushed
the
fix_pdf_download_for_foreman_config_profile
branch
from
c4058d9
to
bc8e579
Compare
lgalis
force-pushed
the
fix_pdf_download_for_foreman_config_profile
branch
from
bc8e579
to
3e33e7b
Compare
|
Checked commits lgalis/manageiq-ui-classic@35092f5~...3e33e7b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lgalis
changed the title
|
@miq-bot add_label bug, fine/yes |
|
@miq-bot add_label configuration management |
|
@dclarizio i think we can close #2172 in favor of this PR since issue is fixed just by moving existing code into a mixin. |
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2017
…fig_profile Fix pdf download for configuration profiles (cherry picked from commit 333c8a0) https://bugzilla.redhat.com/show_bug.cgi?id=1512695
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the identify_record to the manager_mixin to be used for the foreman provider to identify the record based on the tree object
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1471393
To Test : - try to download the pdf for a configuration profile