Reload listnav explorer trees from explorers using RxJS #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
explorer-tree-reload
branch
from
e697205
to
226a242
Compare
|
This pull request is not mergeable. Please rebase and repush. |
skateman
force-pushed
the
explorer-tree-reload
branch
from
226a242
to
9f67c25
Compare
|
Checked commits skateman/manageiq-ui-classic@b8cfd2e~...9f67c25 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating/editing/deleting an item on an explorer screen, we're reloading the trees using
replacePartial. After the angularization of explorer listnav trees this became a bug as these trees are no longer accessible using old CSS selectors.Instead of replacing the whole partial I created an RxJS subscription in the
TreeViewControllerthat expects the updated tree JSON. The data is being sent by theManageIQ.explorerasreloadTreesthat goes way up to theApplicationControllerwhere thereplace_trees_by_presenterhas been renamed toreload_trees_by_presenter.Depends on: ManageIQ/ui-components#145
Parent issue: #1871