Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix limit and request labels for containers #2111

Merged
merged 1 commit into from Sep 6, 2017

Conversation

zeari
Copy link

@zeari zeari commented Sep 5, 2017

Before:
before-limit

After:
after-limit

@martinpovolny @himdel Please review
cc @simon3z

@miq-bot add_label compute/containers, bug

@miq-bot
Copy link
Member

miq-bot commented Sep 5, 2017

Checked commit zeari@b256d79 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/helpers/container_helper/textual_summary.rb

@mzazrivec mzazrivec self-assigned this Sep 6, 2017
@mzazrivec mzazrivec added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 6, 2017
@mzazrivec mzazrivec merged commit 6324bd4 into ManageIQ:master Sep 6, 2017
@simon3z
Copy link
Contributor

simon3z commented Sep 6, 2017

@zeari I have the feeling that generally numbers should be right-aligned (vs text left-aligned). Should we fix that? (check for consistency with the rest of UI).

@zeari
Copy link
Author

zeari commented Sep 11, 2017

@zeari I have the feeling that generally numbers should be right-aligned (vs text left-aligned). Should we fix that? (check for consistency with the rest of UI).

check the screenshots, its pretty consistent with everything pre-existing there.

@himdel Can we make the resource column not as wide? have the values closer to the resource column?

@himdel
Copy link
Contributor

himdel commented Sep 11, 2017

@zeari Not really, no. That's why I was proposing a new kind of textual summary type instead of using tables.

You can try adding some CSS, but.. a html table adapts to its content, so unless you know the expected size and can afford to specifically limit the size of each td to a specific value..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants