Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional flag to check for expected class #2227

Closed

Conversation

bmclaughlin
Copy link
Contributor

This needs to be tested with ManageIQ/manageiq#16034.

This provides an optional parameter that can be tested against to make sure a user doesn't try to import a Widget via the Custom Report form.

@miq-bot add_labels bug, cloud intel/report, pending core

https://bugzilla.redhat.com/show_bug.cgi?id=1442728

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2017

@bmclaughlin Cannot apply the following label because they are not recognized: cloud intel/report

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2017

Checked commit bmclaughlin@4513088 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/controllers/report_controller.rb

  • ⚠️ - Line 76, Col 9 - Lint/UselessAssignment - Useless assignment to variable - reps. Use _ or _reps as a variable name to indicate that it won't be used.

@dclarizio
Copy link

@bmclaughlin @h-kataria is there a test we can add to try to catch this in the future?

@h-kataria
Copy link
Contributor

@bmclaughlin i think it should be easy to add a spec test for this fix, ping me if you need help.

@bmclaughlin
Copy link
Contributor Author

Refactoring of ManageIQ/manageiq#16034 negated the need for this PR. Closing...

@bmclaughlin bmclaughlin closed this Oct 5, 2017
@bmclaughlin bmclaughlin deleted the import-custom-report-error branch October 6, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants